Update of Phase2 Tracker Digitizer to fix an issue in Premixing #42938

suchandradutta · 2023-10-03T18:27:01Z

PR description:

Updating Phase2TrackerDigitizerAlgorithm to fix the issue observed during Premixing of PU events at the Digitization. It was observed that the Digitized signal gets lowered and correspondingly # Digis are lower than expected in inner Pixel layers . It was found that this is due to the fact that the Dual-Slope signal scaling is used. It is now fixed using simple liner scaling of charge during the first step of Pre-Mixing.

Changes are NOT expected! As shown in the validation plots, the PreMixing and noPreMixing show similar behaviour as expected.
NO other PRs or externals it depends upon it
The details of the code change and the validation results are reported to Tk Phase2 Simulation group Link

@emiglior

…arge in # of Digis in inner Pixel modules when Premixing is used during Digitization together with Dual Slope signal scaling

cmsbuild · 2023-10-03T18:32:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42938/37085

This PR adds an extra 24KB to repository

cmsbuild · 2023-10-03T18:33:13Z

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for master.

It involves the following packages:

SimTracker/SiPhase2Digitizer (upgrade, simulation)

@AdrianoDee, @cmsbuild, @mdhildreth, @civanch, @srimanob can you please review it and eventually sign? Thanks.
@dgulhan, @rovere, @VourMa, @mmusich, @missirol, @threus, @mtosi, @VinInn, @JanFSchulte, @GiacomoSguazzoni this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

srimanob · 2023-10-03T18:37:33Z

test parameters:

workflow = 25034.999

srimanob · 2023-10-03T18:40:10Z

@cmsbuild please test

mmusich · 2023-10-03T18:48:53Z

SimTracker/SiPhase2Digitizer/python/phase2TrackerDigitizer_cfi.py

@@ -233,11 +233,17 @@
        AddNoisyPixels = False,
        AddInefficiency = False,
        AddThresholdSmearing = False,
+        Phase2ReadoutMode = -1,
+        AdcFullScale = 255,
+        AddXTalk = False,


I would recommend documenting this here:

cmssw/SimTracker/SiPhase2Digitizer/python/phase2TrackerDigitizer_cfi.py

Lines 219 to 223 in f738fee

# For premixing stage1

# - add noise as by default

# - do not add noisy pixels (to be done in stage2)

# - do not apply inefficiency (to be done in stage2)

# - disable threshold smearing

cmsbuild · 2023-10-03T22:42:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e80085/35029/summary.html
COMMIT: 12a0066
CMSSW: CMSSW_13_3_X_2023-10-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42938/35029/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 2460 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3358320
DQMHistoTests: Total failures: 25646
DQMHistoTests: Total nulls: 35
DQMHistoTests: Total successes: 3332617
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 1 / 48 workflows

srimanob · 2023-10-03T23:10:20Z

Hi @suchandradutta
Could you please confirm that DQM plot shown by PR test is as expected? For example, DigiOccupancyVsEtaP of Barrel IT here.

I assume the change is expected, only Phase-2 PreMix is changed with this PR.

suchandradutta · 2023-10-04T10:28:52Z

Hi @suchandradutta Could you please confirm that DQM plot shown by PR test is as expected? For example, DigiOccupancyVsEtaP of Barrel IT here.

I assume the change is expected, only Phase-2 PreMix is changed with this PR.

@srimanob can you please let me know the workflow number where the difference is seen? So that I can re-run and check.

srimanob · 2023-10-04T11:17:39Z

Hi @suchandradutta Could you please confirm that DQM plot shown by PR test is as expected? For example, DigiOccupancyVsEtaP of Barrel IT here.
I assume the change is expected, only Phase-2 PreMix is changed with this PR.

@srimanob can you please let me know the workflow number where the difference is seen? So that I can re-run and check.

25034.999

…off X-Talk for OT layers alsoat the first step of PreMixing

suchandradutta · 2023-10-05T13:07:51Z

Hi @suchandradutta Could you please confirm that DQM plot shown by PR test is as expected? For example, DigiOccupancyVsEtaP of Barrel IT here.

I assume the change is expected, only Phase-2 PreMix is changed with this PR.

@srimanob I can fully confirm the changes observed in Inner Tracker Digi Occupancy/Charge histograms exactly as expected. I have updated the configuration file with some comments and switched off x-talk simulation also fo outer tracker layers in first step of PreMixing. Test were also done with the updated configuration file.

cmsbuild · 2023-10-05T13:11:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42938/37102

This PR adds an extra 24KB to repository

cmsbuild · 2023-10-05T13:11:49Z

Pull request #42938 was updated. @AdrianoDee, @cmsbuild, @srimanob, @civanch, @mdhildreth can you please check and sign again.

srimanob · 2023-10-05T13:21:31Z

@cmsbuild please test

civanch · 2023-10-08T08:58:22Z

please test

cmsbuild · 2023-10-08T13:16:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e80085/35092/summary.html
COMMIT: 8f397b7
CMSSW: CMSSW_13_3_X_2023-10-08-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42938/35092/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 3060 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3356920
DQMHistoTests: Total failures: 2019
DQMHistoTests: Total nulls: 35
DQMHistoTests: Total successes: 3354844
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 1 / 48 workflows

civanch · 2023-10-09T06:43:09Z

+1

only phase2 WFs are affected, which is expected

srimanob · 2023-10-09T06:49:35Z

+Upgrade

Change on Phase-2 premix workflow is expected.
@civanch do you want the update to present at FullSim meeting?

cmsbuild · 2023-10-09T06:49:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

civanch · 2023-10-09T08:54:34Z

yes, we may discuss this Friday.

antoniovilela · 2023-10-09T16:30:32Z

+1

updating Phase2TrackerDigitizerAlgorithm to fix the issue of lower ch…

12a0066

…arge in # of Digis in inner Pixel modules when Premixing is used during Digitization together with Dual Slope signal scaling

cmsbuild added this to the CMSSW_13_3_X milestone Oct 3, 2023

cmsbuild added simulation-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending trk labels Oct 3, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 3, 2023

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2023

mmusich reviewed Oct 3, 2023

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Oct 3, 2023

updating the configuration file adding proper comments and switching …

8f397b7

…off X-Talk for OT layers alsoat the first step of PreMixing

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Oct 5, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 5, 2023

cmsbuild added tests-started and removed tests-pending labels Oct 5, 2023

cmsbuild added tests-approved and removed tests-started labels Oct 8, 2023

cmsbuild added simulation-approved and removed simulation-pending labels Oct 9, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Oct 9, 2023

cmsbuild added orp-approved and removed orp-pending labels Oct 9, 2023

cmsbuild merged commit 6403d0e into cms-sw:master Oct 9, 2023
12 checks passed

This was referenced Oct 10, 2023

Custom Run 3 PFScouting NanoAOD #40438

Merged

[ROOT6] Updated root to tip of branch master cms-sw/cmsdist#8743

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update of Phase2 Tracker Digitizer to fix an issue in Premixing #42938

Update of Phase2 Tracker Digitizer to fix an issue in Premixing #42938

suchandradutta commented Oct 3, 2023

cmsbuild commented Oct 3, 2023

cmsbuild commented Oct 3, 2023

srimanob commented Oct 3, 2023

srimanob commented Oct 3, 2023

mmusich Oct 3, 2023

cmsbuild commented Oct 3, 2023

srimanob commented Oct 3, 2023

suchandradutta commented Oct 4, 2023

srimanob commented Oct 4, 2023

suchandradutta commented Oct 5, 2023

cmsbuild commented Oct 5, 2023

cmsbuild commented Oct 5, 2023

srimanob commented Oct 5, 2023

civanch commented Oct 8, 2023

cmsbuild commented Oct 8, 2023

civanch commented Oct 9, 2023

srimanob commented Oct 9, 2023

cmsbuild commented Oct 9, 2023

civanch commented Oct 9, 2023

antoniovilela commented Oct 9, 2023

	# For premixing stage1
	# - add noise as by default
	# - do not add noisy pixels (to be done in stage2)
	# - do not apply inefficiency (to be done in stage2)
	# - disable threshold smearing

Update of Phase2 Tracker Digitizer to fix an issue in Premixing #42938

Update of Phase2 Tracker Digitizer to fix an issue in Premixing #42938

Conversation

suchandradutta commented Oct 3, 2023

PR description:

cmsbuild commented Oct 3, 2023

cmsbuild commented Oct 3, 2023

srimanob commented Oct 3, 2023

srimanob commented Oct 3, 2023

mmusich Oct 3, 2023

Choose a reason for hiding this comment

cmsbuild commented Oct 3, 2023

Comparison Summary

srimanob commented Oct 3, 2023

suchandradutta commented Oct 4, 2023

srimanob commented Oct 4, 2023

suchandradutta commented Oct 5, 2023

cmsbuild commented Oct 5, 2023

cmsbuild commented Oct 5, 2023

srimanob commented Oct 5, 2023

civanch commented Oct 8, 2023

cmsbuild commented Oct 8, 2023

Comparison Summary

civanch commented Oct 9, 2023

srimanob commented Oct 9, 2023

cmsbuild commented Oct 9, 2023

civanch commented Oct 9, 2023

antoniovilela commented Oct 9, 2023